PennMUSH Community

Ticket #7648 (closed bug: fixed)

Opened 3 months ago

Last modified 1 month ago

@chan/recall can be used off chan

Reported by: dbwiddis Assigned to:
Priority: minor Milestone: 1.8.3p7
Keywords: Cc:
Visibility: Public

Description

help @channel3 reads, in part: "You must be on a channel to recall from it."

However, this is not the case. Anyone can recall from a channel without being on it. This essentially makes channel locks (other than Admin channels) useless if the channel is buffered.

While this is being fixed, it would be nice if there were an option to prevent recalling in the same manner that hiding must be explicitly allowed.

Attachments

recall-join.patch.txt (1.4 kB) - added by Talvo on 07/02/08 12:46:12.

Change History

07/02/08 12:45:45 changed by Talvo

Recall has to be explicitly turned on by setting up a buffer on the channel, I believe. @chan/buffer <channel>=0 should turn off the buffer (and thus /recall) for the channel.

The patch below edits /recall to check whether you're on the channel or whether you could join it (including the @clock), though, rather than just whether you're on it/pass the channel type checks.

07/02/08 12:46:12 changed by Talvo

  • attachment recall-join.patch.txt added.

07/02/08 12:58:10 changed by dbwiddis

We're aware of the need for buffering, and have turned buffering off on channels for which privacy is a concern. But that removes the ability for members of that channel to use recall.

Thanks for the patch.

09/12/08 18:46:46 changed by raevnos

  • status changed from new to closed.
  • type changed from incoming to bug.
  • resolution set to fixed.
  • milestone set to 1.8.3p7.